Skip to content

Fix a race condition in test_logs#266

Merged
julianstirling merged 1 commit intomainfrom
fix-race-in-logging-test
Feb 25, 2026
Merged

Fix a race condition in test_logs#266
julianstirling merged 1 commit intomainfrom
fix-race-in-logging-test

Conversation

@rwb27
Copy link
Copy Markdown
Collaborator

@rwb27 rwb27 commented Feb 25, 2026

An indentation error in _call_action_can_get_logs meant the test server was shut down before the action completed, causing an intermittent test failure.

I have fixed the indentation and I am fairly sure that will fix the problem.

An indentation error in `_call_action_can_get_logs` meant the test server was shut down before the action completed, causing an error.

I have fixed the indentation and I am fairly sure that will fix the problem.
@rwb27 rwb27 added this to the v0.0.15 milestone Feb 25, 2026
@barecheck
Copy link
Copy Markdown

barecheck bot commented Feb 25, 2026

Barecheck - Code coverage report

Total: 96.5%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@rwb27 rwb27 requested a review from julianstirling February 25, 2026 22:50
@julianstirling
Copy link
Copy Markdown
Contributor

I noticed the same thing and suggested the same change on Signal but I'm not sure you saw that. Glad you came to the same conclusion.

@julianstirling julianstirling merged commit d2b0607 into main Feb 25, 2026
14 checks passed
@julianstirling julianstirling deleted the fix-race-in-logging-test branch February 25, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants